[Bug 629551] Review Request: ghc-gio - Haskell binding to glib's gio

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=629551

Ben Boeckel <mathstuf at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #3 from Ben Boeckel <mathstuf at gmail.com> 2010-09-15 00:14:02 EDT ---
Here is the review:

 +:ok,  NA: not applicable

MUST Items:
[+] MUST: rpmlint output

% lintmock fedora-14-x86_64-bb
ghc-gio.src: W: spelling-error Summary(en_US) Haskell -> Gaskell, Gaitskell,
Skellum
ghc-gio.x86_64: W: spelling-error Summary(en_US) Haskell -> Gaskell, Gaitskell,
Skellum
ghc-gio-devel.x86_64: W: spelling-error Summary(en_US) Haskell -> Gaskell,
Gaitskell, Skellum
ghc-gio-prof.x86_64: E: devel-dependency ghc-gio-devel
ghc-gio-prof.x86_64: W: no-documentation
ghc-gio-prof.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/ghc-6.12.3/gio-0.11.1/libHSgio-0.11.1_p.a
4 packages and 0 specfiles checked; 1 errors, 5 warnings.

Standard. Waived.

[+] MUST: Package Naming Guidelines
[+] MUST: spec file name must match base package %{name}
[+] MUST: Packaging Guidelines.
[+] MUST: Licensing Guidelines
[+] MUST: License field in the package spec file must match actual license.
[+] MUST: include license files in %doc if available in source
[+] MUST: The spec file must be written in American English and be legible.
[+] MUST: source md5sum matches upstream release

% sha1sum gio-0.11.1.tar.gz ../SOURCES/gio-0.11.1.tar.gz
6ecb65d08c82c7253210409c53b593ff6225bda3  gio-0.11.1.tar.gz
6ecb65d08c82c7253210409c53b593ff6225bda3  ../SOURCES/gio-0.11.1.tar.gz

[+] MUST: must successfully compile and build into binary rpms on one main arch

Linked above.

[+] MUST: if necessary use ExcludeArch for other archs
[+] MUST: All build dependencies must be listed in BuildRequires
[+] MUST: use %find_lang macro for .po translations
[+] MUST: packages which store shared library files in the dynamic linker's
default paths, must call ldconfig in %post and %postun.
[+] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review
[+] MUST: A package must own all directories that it creates.
[+] MUST: A package must not contain any duplicate files in the %files listing.
[+] MUST: Permissions on files must be set properly. Every %files section must
include a %defattr(...) line.
[+] MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
[+] MUST: Each package must consistently use macros, as described in the macros
section of Packaging Guidelines.
[+] MUST: The package must contain code, or permissable content.
[+] MUST: Large documentation files should go in a doc subpackage.
[+] MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
[+] MUST: Header files must be in a -devel package.
[+] MUST: Static libraries must be in a -static package.
[+] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package.
[+] MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency
[+] MUST: Packages must NOT contain any .la libtool archives, these should be
removed in the spec.
[+] MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: At the beginning of %install, each package MUST run rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
[+] MUST: All filenames in rpm packages must be valid UTF-8.

SHOULD Items:
[+] SHOULD: The reviewer should test that the package builds in mock.
[+] SHOULD: The package should compile and build into binary rpms on all
supported architectures.
[+] SHOULD: If scriptlets are used, those scriptlets must be sane.

Package APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.