[Bug 515752] Review Request: python-soaplib - python library for creating SOAP services

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515752

Toshio Ernie Kuratomi <a.badger at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |a.badger at gmail.com

--- Comment #25 from Toshio Ernie Kuratomi <a.badger at gmail.com> 2010-09-15 22:53:04 EDT ---
I'll take this:

Good:
* Package named according to the Guidelines and the spec file name matches.
* License is LGPLv2+.  Since this is your first package, I'll just note this in
  case you didn't know: this library is under any version of the LGPL that the
  user chooses since there is no version number specified anywhere in the
  source code.  At present there's only two versions of the LGPL: LGPLv2 and
  LGPLv3 so LGPLv2+ is the license tag that we use.
* LICENSE text is include
* Spec file is readable
* No locales to package
* Not a shared libraries
* Not relocatable
* Permissions set appropriately
* macros used consistently
* Package contains code, not content
* Not a GUI app
* All filenames are valid UTF-8
* Package owns all the files and directories that it creates
* build in koji but see below about unittesting

Needswork:
* There's no soaplib tarball at the specified URL.
  - pypi has a soaplib linked to arksom's account that matches:
    http://github.com/downloads/arskom/soaplib/soaplib-0.8.1.tar
  - pypi has a few soaplibs that are more recent but they're alphas and betas.
    They have tarballs not being generated out of git, though.
  So at minimum, update the Source0: url to be the arksom URL.

* The setup.py says the package requires lxml so you need to add Requires:
  python-lxml

* You should run the unittests::
  %check
  %{__python} setup.py test

  You'll need to make sure that you have all of the Requirements to run the
  package at build time as well:
  BuildRequires: pytz
  BuildRequires: python-lxml

Cosmetic:
* No need to use --optimize=1 in the install.  The rpm byte compile everything
for you.

rpmlint:
python-soaplib.noarch: W: spelling-error %description -l en_US Webservices ->
Web services, Web-services, Services
False positive

python-soaplib.src: W: invalid-url URL: http://wiki.github.com/jkp/soaplib HTTP
Error 404: Not Found
python-soaplib.src: W: invalid-url Source0:
http://github.com/downloads/jkp/soaplib/soaplib-0.8.1.tar HTTP Error 404: Not
Found
These are the problem with the source url no longer existing.  See my notes on
arksom for how to fix.

Do you still need to be sponsored?  If so, we should have you review some other
packages or submit another package to show you know what you're doing.

Here's a couple that I'm interested in seeing get in:

Redis key-value store:
https://bugzilla.redhat.com/show_bug.cgi?id=619237

Python interface for accessing redis key-value stores:
https://bugzilla.redhat.com/show_bug.cgi?id=630339

Backport of python-2.7's ordereddict for earlier python versions
https://bugzilla.redhat.com/show_bug.cgi?id=614299
Note that the packager here is not sponsored so I'll need to work on sponsoring
him too after you do the review :-)

I'm also trying to encourage zope getting in, so you could pick something in
NEW state off of this list as well:
https://bugzilla.redhat.com/showdependencytree.cgi?id=633138&hide_resolved=1

I'd be available on IRC (abadger1999 on irc.freenode.net) or email for you to
ask questions of during the review.  After you review the package I'd take a
look and see if you missed anything before sponsoring you.  And then you'd be
able to approve the package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.