[Bug 632808] Review Request: python-zope-schema - Zope 3 schemas

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=632808

--- Comment #5 from Toshio Ernie Kuratomi <a.badger at gmail.com> 2010-09-16 00:27:51 EDT ---
(In reply to comment #4)
> I hope we can reach some kind of agreements on the above issues, and popularize
> the agreements over all Pyhton packages.
> 
> * About python-setuptools requirement
> In the mechanism of Setuptools, there is no separation of BR and runtime
> requirement. Setuptools is actually a BR for this package, and not used at
> runtime. You may run 'grep -R -e '\(setuptools\|pkg_resources\|easy_install\)'
> src/zope/schema/' to see that. So I think it's no need to require
> python-setuptools.
> 
This is only partially correct.  This package uses setuptools namespaces and
thus it needs setuptools available in order to properly find elements of the
package that may be in multiple directories.  You can test this out by having
python-zope-event installed via rpm into the system site-packages and then
doing
  $ rpmdev-extract python-zope-schema*noarch.rpm
  $ cd python-zope-schema*/usr/lib/python2.?/site-packages
  $ python
  >>> import zope.schema
  >>> ^D
  $ sudo rpm -e --nodeps python-setuptools
  $ python
  >>> import zope.schema
  Traceback (most recent call last):
    File "<stdin>", line 1, in <module>
    File "zope/schema/__init__.py", line 16, in <module>
      from zope.schema._field import Field, Container, Iterable, Orderable
    File "zope/schema/_field.py", line 22, in <module>
      from zope.event import notify
  ImportError: No module named event

> * About tests inclusion
> I now prefer including the tests. First, the tests may be run by users
> themself. Second, we should make as little change as possible to the upstream
> distribution, which is the very spirit of Fedora project.
> 
I'm not too keen on including tests when they're bigger than the code that
drives the package.  However, tests are something that I can consider cosmetic
except.... 

> * About the text files in the module directory.
> I now don't prefer moving that files. First, if the tests are included, the
> text files are possibly needed in the module directory by the tests. Second, in
> those text files, expressions referring to the modules in the same directory
> may be employed, for example, 'Please refer to interface.py in this directory.'
> Third, in some bigger packages, the text files will spread over levels of
> directories, moving those files makes maintenance more difficult.
> 

The text files in this package are documentation.  They must be marked as
documentation and put into %{_docdir}.  The tests rely on the text, so it seems
strange to leave the tests in the module directory when the text files that
they need have been moved where the tests can't find them.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.