[Bug 633549] Review Request: rubygem-linode - Ruby wrapper for the Linode API

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=633549

--- Comment #2 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-09-17 13:38:25 EDT ---
For 0.6.2-1:

* Dependency
  - Writing ">= 0.4.4" on "(Build)Requires: rubygem(httparty)" is not needed
    https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires

  - If you use "BuildRequires(check)" syntax, I guess
    "rubygem(mocha)" "rubygem(httparty)" are needed only for %check so
    using "BR(check)" is apppropriate
    ! Note that rubygem(httparty) is also needed for Requires, as you already
      wrote so.

* %{geminstdir}/linode.gemspec
  - Would you check if this is really needed?

* %doc attribute in -doc subpackage
  - I think writing %doc attribute in -doc subpackage is redundant because
    the name of the rpm already indicates that the rpm is for documentation.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.