[Bug 634388] Review Request: python-chameleon - XML-based template compiler
bugzilla at redhat.com
bugzilla at redhat.com
Sat Sep 18 08:35:31 UTC 2010
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=634388
--- Comment #6 from Robin Lee <robinlee.sysu at gmail.com> 2010-09-18 04:35:30 EDT ---
Good:
* Package named according to the packaging guidelines
* Spec matches package name
* spec file readable
* Source matches upstream
* No locale specific files
* Not a shared library
* No bundled libraries
* Not relocatable
* Owns the files and directories it creates and nothing more
* Permissions set properly
* Consistent use of macros
* code, not content.
* Not a GUI
* All filenames UTF-8
* builds in koji
* License is BSD in source and spec
NEEDWORK:
* /usr/lib/python2.7/site-packages/chameleon/ast/COPYING must be moved to
/usr/share/doc/python-chameleon-1.2.12/ast
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list