[Bug 589866] Review Request: darktable - Utility to organize and develop raw images

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=589866

--- Comment #34 from Peter Lemenkov <lemenkov at gmail.com> 2010-09-19 13:48:01 EDT ---
Koji scratchbuild for F-13:

http://koji.fedoraproject.org/koji/taskinfo?taskID=2476044

+/- rpmlint isn't completely silent:

work ~/Desktop: rpmlint darktable-*
darktable.i686: W: non-conffile-in-etc /etc/gconf/schemas/darktable.schemas
darktable.i686: W: dangerous-command-in-%pre rm
darktable.i686: W: dangerous-command-in-%post rm
2 packages and 0 specfiles checked; 0 errors, 3 warnings.
work ~/Desktop:

Should /etc/gconf/schemas/darktable.schemas be really treated as unchangeable
by user?

- The package does NOT meet the Packaging Guidelines fully:

1. Please, remove the following directory
$RPM_BUILD_ROOT%{_datadir}/doc/darktable at the end of  %install section - you
later marked all necessary files as docs and they will be automatically
installed by rpmbuild properly (with name and version of package).
2. Typo in one %changelog entry:
* Fri Sep 10 2010 Edouard Bourguignon <<madko at linuxed.net>
note -  double forward angle bracket.
3. BuildRequires:  gegl-devel mentioned twice. Please remove the first one.\
4. Please, take a look at the build logs. What warns me is basically two
things. First, message "configure: WARNING: unrecognized options:
--disable-schemas" - please fix/remove it. Second - although build data was
built, I found this message during configuration - "checking whether to enable
debugging... no". What this message means exactly? Does that mean some kind of
run-time logging or something to deal with "strip"?
5. During configure stage the application performs the following test -
"checking pkg-config is at least version 0.22... yes", and you didn't specify
the required number of pkg-config in spec-file - please fix that.
6. Regarding %{withgegl} macro - I believe that the proper form is %{with_gegl}
(note the underscore). Please try to rebuild --with-gegl and see whether this
switch is actually working or not.
7. Bundled library - src/LibRaw. It was already packaged for Fedora, so please
remove it and build against system-wide copy (you should patch application if
it doesn't allow this). Or please explain why it can't be done simply (forked
and patched copy of library, as example).


That's all so far.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.