[Bug 630208] Review Request: ghc-csv - CSV loader and dumper

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=630208

Jens Petersen <petersen at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |petersen at redhat.com

--- Comment #4 from Jens Petersen <petersen at redhat.com> 2010-09-19 20:25:36 EDT ---
(In reply to comment #1)
> I am utterly unfamiliar with Haskell.  I'm happy to negotiate on any point,
> given my ignorance.

Thanks for your good comments and input.

> Since ghc-csv-prof is a profiling package, I assume that its errors and
> warnings are irrelevant.  A comment to this effect in the .spec would be nice.

Good point: we should document that in the fedora wiki
and add a link to our spec files.

> [-] MUST: The spec file for the package MUST be legible.
> 
> There is apparently some pretty good voodoo in ghc-rpm-macros.  I'd like to see
> some comments describing that this is the reason for common_summary being
> defined buy only appearing once and the outright lack of %files and %doc - at
> least, I'm assuming that that's the reason.  As-is, I'd say that this .spec
> file is not legible to someone without an existing ghc background.

Agreed - ditto as above.

> I'm assuming that ghc-rpm-macros enforces this, but I have no easy way of
> knowing.  Legibility is not there.

Not obvious again but you can see the filelists on the src build dir.

> ghc-csv-devel contains /usr/lib64/ghc-6.12.3/csv-0.1.1/libHScsv-0.1.1.a; I'm
> unsure if this is qualifies as a static library.

It does unfortunately but ghc still assumes static libs by
default so they can't be subpackaged yet.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.