[Bug 635453] Review Request: deafshell - Deaf Shell is used for system accounts dedicated to ssh port forwarding

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=635453

Mark McKinstry <mmckinst at nexcess.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mmckinst at nexcess.net

--- Comment #1 from Mark McKinstry <mmckinst at nexcess.net> 2010-09-19 23:34:12 EDT ---
François,

A few comments:

1. The license should be GPLv3+
2. You could replace the setup and prep sections with just ''%setup -q -n
%{name}-%{name}-88674c3'
3. In the build section, it should just be 'make' otherwise rpmlint in unhappy
with the unstripped binary
4. In the files section, you should specify the binary as '%{_bindir}deafshell'

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.