[Bug 589866] Review Request: darktable - Utility to organize and develop raw images

bugzilla at redhat.com bugzilla at redhat.com
Mon Sep 20 10:33:11 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=589866

--- Comment #38 from Peter Lemenkov <lemenkov at gmail.com> 2010-09-20 06:33:06 EDT ---
Again regarding №4 - you already addressed all my complaints by removing
obsolete configure switch. My concerns were that not using debug-related switch
may cause issues with generating debuginfo but I checked ant it seems that this
switch has nothing to do with GDB data.

So just proceed with issue №7.

As for №1, I'll take a look again, but I'm suspecting that you removed it in
the wrong way (for example, only from %files but not from rpm_build_root).

One more (mostly cosmetic) issue - please consistently use macros. Sometimes
you;re using %{buildroot} and sometimes  $RPM_BUILD_ROOT. Please use only one
of these two.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


More information about the package-review mailing list