[Bug 587198] Review Request: jgraphx - Java Graph Drawing Component

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=587198

--- Comment #11 from Lubomir Rintel <lkundrak at v3.sk> 2010-09-20 15:09:58 EDT ---
(In reply to comment #8)
> Just a few things for now.
> 
> According to https://fedoraproject.org/wiki/Packaging:Java
> 
> At a minimum, Java packages MUST:
> 
> BuildRequires: java-devel [>= specific_version] 
> BuildRequires:  jpackage-utils
> 
> Requires:  java >= specific_version
> Requires:  jpackage-utils
> 
> Group for javadoc should be "Development/Documentation"
> Think about adding "Requires: Requires: %{name}-%{version}-%{release}
> " to javadoc subpackage.
> 
> 
> SOURCE0 is not a vaild URL. Try using:
> "http://www.jgraph.com/downloads/jgraphx/archive/%{name}-%(echo %{version} |sed
> 's/\./_/g').zip"

All of above fixed. Thanks!

> Your BuildRoot seams a little odd. Think about using
> "%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)" instead.

It's not. It's one of the permitted forms, and actually a preferred one. Not
that it would matter, just the above one makes concurrent package builds racy
with older rpm.

> "find -name '*.jar' -delete" and "rm -rf docs/api" should be moved to "%prep".
> It is also a good idea to add "find -name '*.class' -delete" too.

I could not find a definitive reason to do this and am keeping it as it is for
consistency with existing packages (and a personal bias :); until I'm convinced
otherwise (by a guideline or piece of rpm documentation).

(In reply to comment #9)
> For your information, jgraphx is regularly breaking backward compatibility (the
> compilation will work but the application based on jgraphx will fails). 
> 
> If you package jgraphx 1.4.0.2, it will break some behavior of Scilab. Scilab
> 5.2.2 expects jgraphx 1.2.0.8.
> 
> I can ask to the developer of the Scilab jgraphx-based component for a patch.

I quite honestly don't care. I won't mind a compatibility patch though, nor a
compat package if needed, nor helping out anywhere (if needed).

SPEC: http://v3.sk/~lkundrak/jgraphx.spec
SRPM: http://v3.sk/~lkundrak/jgraphx-1.4.1.0-1.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.