[Bug 635654] Review Request: perl-Text-Hunspell - Perl interface to the Hunspell library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=635654

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
               Flag|                            |fedora-review+

--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> 2010-09-21 05:48:49 EDT ---
Review:
+ package builds in koji (f15).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2478975
+ rpmlint is silent for SRPM and for RPM.

+ source files match upstream url (sha1sum)
ce21d98e2ba4d2de0bf54cb56fcaee0982830c0d  Text-Hunspell-2.01.tar.gz
ce21d98e2ba4d2de0bf54cb56fcaee0982830c0d  Text-Hunspell-2.01.tar.gz.srpm

+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present which is not needed now.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no -devel subpackage
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=5, Tests=16,  0 wallclock secs ( 0.03 usr  0.01 sys +  0.22 cusr  0.05
csys =  0.31 CPU)
+ Not a GUI application


Suggestions
1) If there are no plans to add this package < F13 releases then please
  a) remove buildroot
  b) remove cleaning of buildroot in %install
  c) remove %clean section

2) Is versioned BR: needed in this package?
hunspell-devel >= 1.2.8
   If not then please remove it.


APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.