[Bug 634700] Review Request: python3-cairo - cairo python bindings for Python 3

Wed Sep 22 18:10:11 UTC 2010

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=634700

--- Comment #19 from John (J5) Palmieri <johnp at redhat.com> 2010-09-22 14:10:10 EDT ---
(In reply to comment #18)
> Thanks!  Mostly looking good, but there are a few specific things that ought to
> be fixed.
> 
> === "MUST" items that need work ===
> (Please do bump the release number when fixing these!)
> 
> > MUST: If (and only if) the source package includes the text of the license(s)
> > in its own file, then that file, containing the text of the license(s) for
> > the package must be included in %doc.[4]
> 
> You've done this for the main package, but I believe you need a duplicate copy
> of these licenses in the "devel" subpackage as well.

Really?  The devel package requires the main package which will install the
license.  Can you point to the policy.  This is the first I have heard of it.
Added the doc line in any case.

> > MUST: Packages must NOT bundle copies of system libraries
> 
> The upstream tarball embeds a copy of "waf" for use during the build, but "waf"
> is packaged within Fedora.
> 
> Is it possible to use the system copy of "waf"?  Please try removing the
> embedded copy of "waf" in the %prep and add a:
>   BuildRequires: waf
> and you'll need to change all the references to "./waf" in the specfile
> accordingly.
> 
> There was some discussion of this here:
> http://lists.fedoraproject.org/pipermail/packaging/2009-February/005722.html
> has some notes on this.

I was told to use the internal waf, or at least that is what other packages are
doing. 

Actually this needs to be waved.  At least on F13 the waf files are not Python3
compliant.  I would like to wait for waf to become more mature before depending
on the system version.

> 
> > MUST: A package must own all directories that it creates. If it does not
> > create a directory that it uses, then it should require a package which does
> > create that directory. [13]
> 
> and
> 
> > MUST: Packages must not own files or directories already owned by other
> > packages. The rule of thumb here is that the first package to be installed
> > should own the files or directories that other packages may rely upon. This
> > means, for example, that no package in Fedora should ever share ownership
> > with any of the files or directories owned by the filesystem or man package.
> > If you feel that you have a good reason to own a file or directory that
> > another package owns, then please present that at package review time. [23]
> 
> Is this directory also used by the python 2 package?
>   %{_includedir}/pycairo/
> 
> Looks like it might be tricky to fix whilst staying close to upstream's intent.

Not an issue.  I can have python3-cairo only own the files in that directory. 
When we switch to python3 as the default we will have pycairo drop ownership
and python3-cairo take ownership.

> > MUST: Each package must consistently use macros. [16]
> You use %{optflags} in one place, and $RPM_BUILD_ROOT in others.  To be
> nitpicking, this appears to be a violation of:
> http://fedoraproject.org/wiki/Packaging/Guidelines#macros
> IMHO of minimal benefit, but please fix it when fixing the other issues.

Will do.  I hate how we don't just pick one :( 

We allow you to make things look ugly but don't do it - you can choose which
one you like and do that.  Choice is good.  Choice is Mother.  Choice is
Father.  Choose one but just not that one.

> === Other notes ===
> (i) Please can you file a bug usptream about the PyCObject issue mentioned in
> comment #2 and comment #4 (and add a URL here)?  I hope to rebase us to
> python-3.2 in Fedora 15, and the latest 3.2a2 removes this deprecated API,
> which would lead to a FTBFS.
>   https://fedoraproject.org/wiki/Features/Python_3.2

Sorry, already did but didn't tell you -
https://bugs.freedesktop.org/show_bug.cgi?id=30289

> (ii) The "doc" directory does contain rst documentation, along with
> instructions for building it to html.  I don't think that doing so is a blocker
> for review, perhaps an RFE for further work.

We don't do anything for pycairo so RFE would be right here.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.