[Bug 636250] Review Request: HotEqn - Java Library to display LateX Code - Dependency for Freemind

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=636250

Jussi Lehtola <jussi.lehtola at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jussi.lehtola at iki.fi

--- Comment #4 from Jussi Lehtola <jussi.lehtola at iki.fi> 2010-09-22 17:27:45 EDT ---
A few notes, I hope Orion doesn't mind:

- The URL should really be something like
 http://www.esr.ruhr-uni-bochum.de/VCLab/software/HotEqn/HotEqn.html
which contains information about HotEqn. Pointing to a directory containing
just a source tarball is pointless.

- Note that the summary should read 
 "An equation viewer for Java"
However, I think the following would be an even better summary:
 "A LaTeX equation viewer Java applet"
since HotEqn uses the LaTeX syntax, and there are a few other equation markup
languages around.

- Your Source1 is missing a comment in the spec file, detailing what it is and
where does it come from.

- There's absolutely no need to refer to %{_builddir} in the spec file, and it
is often considered bad style. Since you are by default in the build dir, you
can change

 cp %{SOURCE1} %{_builddir}/%{name}
to
 cp -p %{SOURCE1} .
(-p preserves time stamp)

and

 mkdir %{_builddir}/%{name}/src
 cp %{_builddir}/%{name}/*.java %{_builddir}/%{name}/src
to
 mkdir src
 cp *.java src/

and
 install -d -m 755 %{buildroot}/%{_javadir}
 install -m 644 %{_builddir}/%{name}/build/jar/%{name}.jar \
 %{buildroot}/%{_javadir}/%{name}.jar
to
 install -D -m 644 build/jar/%{name}.jar %{buildroot}/%{_javadir}/%{name}.jar
(this command also creates the necessary directories)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.