[Bug 540885] Review Request: cableswig - Create interfaces to interpreted languages for templated code

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=540885

Peter Lemenkov <lemenkov at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #12 from Peter Lemenkov <lemenkov at gmail.com> 2010-09-23 01:43:08 EDT ---
Ok, good.

REVIEW:

Legend: + = PASSED, - = FAILED, 0 = Not Applicable

+ rpmlint is almost silent

Sulaco ~: rpmlint Desktop/CableSwig-*
CableSwig.ppc: W: spelling-error Summary(en_US) templated -> templates,
template, temp lated
CableSwig.ppc: W: no-documentation
CableSwig.ppc: W: no-manual-page-for-binary cswig
CableSwig.ppc: W: no-manual-page-for-binary cableidx
2 packages and 0 specfiles checked; 0 errors, 4 warnings.
Sulaco ~: 

+ The package is named according to the  Package Naming Guidelines .
+ The spec file name matches the base package %{name}, in the format
%{name}.spec.
+ The package meets the Packaging Guidelines .
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines .
+ The License field in the package spec file matches the actual license. (BSD)
+ The file, containing the text of the license(s) for the package, is included
in %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package matches the upstream source, as
provided in the spec URL.

Sulaco ~/rpmbuild/SOURCES: sha256sum CableSwig-ITK-3.20.0.tar.gz*
0faef127a9881212faf3e9105d77637ba124cc48d10446005a515ed2502828b6 
CableSwig-ITK-3.20.0.tar.gz
0faef127a9881212faf3e9105d77637ba124cc48d10446005a515ed2502828b6 
CableSwig-ITK-3.20.0.tar.gz.1
Sulaco ~/rpmbuild/SOURCES:

+ The package successfully compiles and builds into binary rpms on at least one
primary architecture. See koji link above.
+ All build dependencies are listed in BuildRequires.
0 No need to handle locales.
0 The package does not store shared library files in any of the dynamic
linker's default paths.

+/- The package does bundle copy of application, already available in Fedora, -
SWIG. But the whole idea of CableSwig is to fork SWIG and deeply patch it. More
to say - SWIG doesn't provide a library to ling against it, so if anyone would
like to re-use SWIG codebase, then there is no other way when forking it. So
this is NOT a blocker.

0 The package is NOT designed to be relocatable.
+ The package owns all directories that it creates.
+ The package does not list a file more than once in the spec file's %files
listings.
+ Permissions on files are set properly.
+ The package consistently uses macros.
+ The package contains code, or permissible content.
0 No extremely large documentation files.
+ Anything, the package includes as %doc, does not affect the runtime of the
application.
0 No C/CPP header files.
0 No static libraries.
0 The package does not contain library files.
0 No devel sub-package
+ The package does NOT contain any .la libtool archives.
0 Not a GUI application
+ The packages does not own files or directories already owned by other
packages.
+ All filenames in rpm packages are valid UTF-8.


This package is


APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.