[Bug 631898] Review Request: fatrat - Feature-rich download manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=631898

Jan Vcelak <jvcelak at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|needinfo?(jvcelak at redhat.co |needinfo?(jkaluza at redhat.co
                   |m)                          |m)

--- Comment #2 from Jan Vcelak <jvcelak at redhat.com> 2010-09-23 07:30:45 EDT ---
(In reply to comment #1)
> If you don't plan to have Fatrat in EPEL5 and below, you do not need to define
> "BuildRoot:..." anymore, rpmbuild will use a sane one automatically (since
> F-10).
> You also do not need to clean the buildroot manually at the beginning of
> %install (since F-10).
> http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
> 

I don't think this is critical. And I would rather leave both things there
(BuildRoot and clean), if someone wanted to build it for older Fedora or EPEL.
In addition, removing these will emit new rpmlint warnings.

> [ERR] GUI app must include a %{name}.desktop and use desktop-file-install
> 
> > $desktop-file-validate fatrat.desktop 
> > fatrat.desktop: warning: value "Application;Network;" for key "Categories" in group "Desktop Entry" contains a deprecated value "Application"
> > fatrat.desktop: warning: value "fatrat.png" for key "Icon" in group "Desktop Entry" is an icon name with an extension, but there should be no extension as described in the Icon Theme Specification if the value is not an absolute path
> 
> I'm not sure if that's real problem, but it would be fine to have it fixed.
> 

This is being fixed during %install. See the lines under "update desktop file"
comment. The binary package contains valid desktop file.

(I'm using sed to fix it, as desktop-file-install can't handle that.)

> [ERR] Icon tag in Desktop Files
> 
> mentioned above
> 

Above as well. ;-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.