[Bug 627197] Review Request: bluedevil - Bluetooth stack for KDE

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=627197

Radek Novacek <rnovacek at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #1 from Radek Novacek <rnovacek at redhat.com> 2010-09-23 10:45:47 EDT ---
This package looks good, except of rpmlint errors.

invalid-soname - libbluedevilaction.so should have some version and -devel
package should have unversioned symlink to it. Same applies for libraries in
/usr/lib(64)/kde4.

invalid-desktopfile - "Bluetooth;" should be removed from the Categories key
since standard defines this as valid category, see [1].

invalid-desktopfile - "virtual/bluedevil-*;" is invalid MIME type. But I'm not
sure if removing it don't break some functionality.

Except of the this issues the package is ok and functional (I tested
bidirectional sending files between desktop and mobile phone and it works).
Setting review+.

[1] http://standards.freedesktop.org/menu-spec/latest/apa.html

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.