[Bug 636946] Review Request: perl-Astro-FITS-Header - Object Orientated interface to FITS HDUs
bugzilla at redhat.com
bugzilla at redhat.com
Fri Sep 24 12:52:49 UTC 2010
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=636946
--- Comment #1 from Petr Pisar <ppisar at redhat.com> 2010-09-24 08:52:48 EDT ---
Source file original.
License verified from lib/Astro/FITS/Header.pm.
TODO: %doc GPL file contains GPL-2 version but source files states perl license
(GPL-1). Report bug to upstream.
All test pass.
FIX: Missing BuildRequires for %check phase: perl(Starlink::AST),
perl(Astro::FITS::CFITSIO), perl(GSD), perl(NDF)
TODO: Remove unneeded BuildRoot because this post-F12 spec.
$ rpmlint perl-Astro-FITS-Header.spec
../SRPMS/perl-Astro-FITS-Header-3.01-1.fc13.src.rpm
../RPMS/noarch/perl-Astro-FITS-Header-3.01-1.fc13.noarch.rpm
perl-Astro-FITS-Header.spec: W: no-cleaning-of-buildroot %clean
perl-Astro-FITS-Header.spec: W: no-%clean-section
perl-Astro-FITS-Header.src: W: spelling-error %description -l en_US arguement
-> argument, arrangement, enlargement
perl-Astro-FITS-Header.src: W: no-cleaning-of-buildroot %clean
perl-Astro-FITS-Header.src: W: no-%clean-section
perl-Astro-FITS-Header.noarch: W: spelling-error %description -l en_US
arguement -> argument, arrangement, enlargement
2 packages and 1 specfiles checked; 0 errors, 6 warnings.
FIX: Description spelling is incorrect.
$ rpm -pq --requires
../RPMS/noarch/perl-Astro-FITS-Header-3.01-1.fc13.noarch.rpm | sort |uniq -c
1 perl(Astro::FITS::CFITSIO)
1 perl(Astro::FITS::Header::Item)
1 perl(base)
1 perl(Carp)
1 perl(File::Spec)
1 perl(GSD)
1 perl(:MODULE_COMPAT_5.10.1)
1 perl(NDF)
1 perl(overload)
1 perl(Starlink::AST)
1 perl(strict)
1 perl(vars)
1 perl(warnings)
1 perl >= 0:5.006
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
1 rpmlib(VersionedDependencies) <= 3.0.3-1
Binary dependencies Ok.
FIX: Missing perl(File::Spec) BuildRequires for %check phase (dual-life package
possible).
$ rpm -pq --provides
../RPMS/noarch/perl-Astro-FITS-Header-3.01-1.fc13.noarch.rpm | sort |uniq -c
1 perl(Astro::FITS::Header::AST) = 3.01
1 perl(Astro::FITS::Header::CFITSIO) = 3.01
1 perl(Astro::FITS::HeaderCollection)
1 perl(Astro::FITS::Header::GSD) = 3.01
1 perl(Astro::FITS::Header::Item) = 3.01
1 perl(Astro::FITS::Header::NDF) = 3.01
1 perl(Astro::FITS::Header) = 3.01
1 perl-Astro-FITS-Header = 3.01-1.fc13
Binary provides Ok.
$ rpm -pqlv ../RPMS/noarch/perl-Astro-FITS-Header-3.01-1.fc13.noarch.rpm
drwxr-xr-x 2 root root 0 zář 24 14:20
/usr/share/doc/perl-Astro-FITS-Header-3.01
-rw-r--r-- 1 root root 15663 bře 17 2009
/usr/share/doc/perl-Astro-FITS-Header-3.01/ChangeLog
-rw-r--r-- 1 root root 18009 úno 11 2009
/usr/share/doc/perl-Astro-FITS-Header-3.01/GPL
-rw-r--r-- 1 root root 6532 bře 17 2009
/usr/share/doc/perl-Astro-FITS-Header-3.01/README
-rw-r--r-- 1 root root 251 úno 11 2009
/usr/share/doc/perl-Astro-FITS-Header-3.01/TODO
-rw-r--r-- 1 root root 7920 zář 24 14:20
/usr/share/man/man3/Astro::FITS::Header.3pm.gz
-rw-r--r-- 1 root root 2560 zář 24 14:20
/usr/share/man/man3/Astro::FITS::Header::AST.3pm.gz
-rw-r--r-- 1 root root 2686 zář 24 14:20
/usr/share/man/man3/Astro::FITS::Header::CFITSIO.3pm.gz
-rw-r--r-- 1 root root 2523 zář 24 14:20
/usr/share/man/man3/Astro::FITS::Header::GSD.3pm.gz
-rw-r--r-- 1 root root 3905 zář 24 14:20
/usr/share/man/man3/Astro::FITS::Header::Item.3pm.gz
-rw-r--r-- 1 root root 3279 zář 24 14:20
/usr/share/man/man3/Astro::FITS::Header::NDF.3pm.gz
drwxr-xr-x 2 root root 0 zář 24 14:20
/usr/share/perl5/Astro
drwxr-xr-x 2 root root 0 zář 24 14:20
/usr/share/perl5/Astro/FITS
drwxr-xr-x 2 root root 0 zář 24 14:20
/usr/share/perl5/Astro/FITS/Header
-rw-r--r-- 1 root root 48951 bře 17 2009
/usr/share/perl5/Astro/FITS/Header.pm
-rw-r--r-- 1 root root 3350 bře 17 2009
/usr/share/perl5/Astro/FITS/Header/AST.pm
-rw-r--r-- 1 root root 7819 bře 17 2009
/usr/share/perl5/Astro/FITS/Header/CFITSIO.pm
-rw-r--r-- 1 root root 3921 bře 17 2009
/usr/share/perl5/Astro/FITS/Header/GSD.pm
-rw-r--r-- 1 root root 21751 bře 17 2009
/usr/share/perl5/Astro/FITS/Header/Item.pm
-rw-r--r-- 1 root root 11376 bře 17 2009
/usr/share/perl5/Astro/FITS/Header/NDF.pm
Files permissions and location Ok.
Spec file in line with Perl packaging guidelines.
Builds on F15 (http://koji.fedoraproject.org/koji/taskinfo?taskID=2486777).
Please fix all `FIX:' prefixed comments and publish new spec file.
I'd like to see skipped tests to proceed by BuildRequirig missing dependencies.
If you are in strong opposition, argue please. I could weak them onto TODO
level.
Result: NOT APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list