[Bug 623604] Review Request: xneur - X Neural Switcher

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=623604

--- Comment #4 from Martin Gieseking <martin.gieseking at uos.de> 2010-09-24 09:17:33 EDT ---
(In reply to comment #3)
> > - libxnconfig and xneur contain rpaths (see rpmlint output below). 
> >   The rpath must be removed.
> >   http://fedoraproject.org/wiki/Packaging/Guidelines#Beware_of_Rpath
> It is not problem for internal libraries -
> http://fedoraproject.org/wiki/Packaging/Guidelines#Rpath_for_Internal_Libraries

Since you provide a -devel subpackage, libxneur isn't purely internal to the
bundled xneur utility. A future package might BR: xneur-devel and depend on
libxneur. Hence, you should remove the rpath.


> >   %{_mandir}/man1/xneur.1*
> >   %{_mandir}/man5/xneurrc.5*
> I do not see any worth on it - we always want include all available mans.

The more verbose variants prevent accidentally installing files into wrong
places in future releases. I already came across packages with man3 files in
the man1 folder, and also non-manual files in one of the man folders. This was
because "make install" put them into the wrong directory. Using the above
mentioned lines would have made rpmbuild fail with an error. Thus, I recommend
to use the more explicit lines in %files. It helps keeping the package clean.


> > $ rpmlint /var/lib/mock/fedora-13-x86_64/result/*.rpm
> > xneur.src: I: enchant-dictionary-not-found ru
> If I understand it correctly - you just do not have installed ru dictionary for
> hunspell and rpmlint can't spell it language.

Right. The warning can be ignored.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.