[Bug 619593] Review Request: topgit - A different patch queue manager

bugzilla at redhat.com bugzilla at redhat.com
Sun Sep 26 13:18:24 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=619593

--- Comment #5 from Thomas Moschny <thomas.moschny at gmx.de> 2010-09-26 09:18:23 EDT ---
(In reply to comment #4)
> [FAIL] MUST: The sources used to build the package must match the upstream
> source, as provided in the spec URL. Reviewers should use md5sum for this task.
> If no upstream URL can be specified for this package, please see the Source URL
> Guidelines for how to deal with this.
> 
> % sha1sum 5aed7e7bad8c23080139b452adac75d2571b6dfa.tar.gz
> ../SOURCES/5aed7e7bad8c23080139b452adac75d2571b6dfa.tar.gz
> 1b38e02c8f55a9029c081562aaec3e787614689e 
> 5aed7e7bad8c23080139b452adac75d2571b6dfa.tar.gz
> c0a1ea211a7eb4732987cc299c44095a7f41673d 
> ../SOURCES/5aed7e7bad8c23080139b452adac75d2571b6dfa.tar.gz
> 
> Tarball was fetched with `spectool -g`.

Yeah, the problem is gitweb, which seems to embed a datestamp or something like
this in the tarfile, causing it to have a different hash each time one
downloads it.

I changed the specfile to refer to the zipfile instead, which doesn't seem to
have that problem.

(Note that this problem would persist even when we don't packaged a git
snapshot, but a released version, as there currently is no real upstream
website other than gitweb.)

> [FAIL] MUST: A package must own all directories that it creates. If it does not
> create a directory that it uses, then it should require a package which does
> create that directory.
> 
> /etc/bash_completion.d/ isn't owned. I'd recommend splitting off the bash
> completion into a separate file and Requires: topgit and Requires:
> bash-completion.

That's overkill imho. Following what other packages do, I simply own
/etc/bash_completion.d now.

> One weird thing I see is %doc at the end of %files.

Moved to the top of the %files section.

> I'd also recommend adding a
> trailing slash to the %{_libexecdir} and %{_datarootdir} lines to better
> indicate that they are directories.

Slashes added.


Spec URL: http://thm.fedorapeople.org/topgit/topgit.spec
SRPM URL:
http://thm.fedorapeople.org/topgit/topgit-0.8-2.git9404aa1a.fc13.src.rpm

%changelog
* Mon Sep 13 2010 Thomas Moschny <..> - 0.8-2.git9404aa1a
- Update to revision 9404aa1a.
- Specfile fixes as suggested in the review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list