[Bug 636819] Review Request: gnome-exe-thumbnailer - gnome thumbnailer for exe files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=636819

--- Comment #4 from Arun SAG <sagarun at gmail.com> 2010-09-26 09:28:05 EDT ---
(In reply to comment #3)
> I've updated the spec file and the src.rpm according to your review.
> 

1. When you update a spec file, you need to increase (bump) the Release: by 1
and tell about your modifications in Changelog. This is how we track all the
modifications done to  a spec file. You haven't done that.

2. Please update your SRPM as well, not just the spec file and provide the
links here.


your %install section is wrong,

>install -D gnome-exe-thumbnailer.sh $RPM_BUILD_ROOT%{_bindir}/gnome-exe-thumbnailer.sh

Why do you want above line?

> is it possible to use the %{name} maro in the files section of the spec?

yes you can use the macro anywhere in the spec file.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.