[Bug 543154] Review Request: mingw32-SDL_mixer - Simple DirectMedia Layer's Sample Mixer Library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=543154

--- Comment #9 from Erik van Pienbroek <erik-fedora at vanpienbroek.nl> 2010-09-27 06:52:07 EDT ---
Please don't use the release number 0, but start with 1. Other packages use
release number 0 to indicate pre-releases, but as that isn't the case here you
can start with 1.

I noticed you've used the %{_mingw32_debug_package} macro to generate a
debuginfo subpackage. This is okay, but it requires an additional line at the
top of the .spec file (other packages put it under the last %global line) :
%define __debug_install_post %{_mingw32_debug_install_post}

Libtool files (.la) need to be part of mingw32 packages, so please don't drop
them

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.