[Bug 543147] Review Request: mingw32-SDL_image - MinGW Windows port of the Image loading library for SDL

bugzilla at redhat.com bugzilla at redhat.com
Mon Sep 27 11:35:35 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=543147

Erik van Pienbroek <erik-fedora at vanpienbroek.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |erik-fedora at vanpienbroek.nl
               Flag|                            |fedora-review?

--- Comment #6 from Erik van Pienbroek <erik-fedora at vanpienbroek.nl> 2010-09-27 07:35:34 EDT ---
Taking this for review.
My comments from bug 543154 (mingw32-SDL_mixer) also apply to this package.

In addition, is the line mkdir -p $RPM_BUILD_ROOT%{_bindir} really necessary?
It doesn't make sense to me to create an empty %{_bindir} which isn't used in
the rest of the .spec file

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list