[Bug 587011] Review Request: tboot - uses Intel(R) TXT to perform a measured and verified launch of a kernel/VMM

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=587011

--- Comment #6 from Miloslav Trmač <mitr at redhat.com> 2010-09-27 15:44:03 EDT ---
(In reply to comment #5)
> This fixes all of the above comments except the debuginfo package.  I changed
> %build and %install to call make with 'debug=y', which causes the makefiles to
> compile with '-g' and removes the '-s' from the install commands.  However, no
> debuginfo package is created and rpmlint warns about unstripped binaries. 
> Everything I've been able to find on debuginfo packages seems to indicate that
> as long as the binaries are compiled with '-g' and not stripped, that 'rpmbuild
> -ba' "should just work" to make a debuginfo package.  Your wisdom on this is
> greatly appreciated.

"%global debug_package %{nil}" was left on the top of the spec file.  Removing
it seems to produce reasonable results.

> (In the case of tboot.gz, the makefile explicitly strips
> the symbols out itself and creates a tboot-syms file, which it always copies to
> /boot.)
That should be good enough considering that this can't be debugged from within
a running system anyway.


I'm sorry, another thing:
https://fedoraproject.org/wiki/PackagingGuidelines#Compiler_flags  - Perhaps
not for the kernel-mode part, but the user-space utilities should use these
flags in CFLAGS.  This will probably require some changes to the makefile
system, collecting user-space flags into a variable that can be overridden from
the spec file..

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.