[Bug 225719] Merge Review: efax

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225719

--- Comment #2 from Ngo Than <than at redhat.com> 2010-09-29 09:36:28 EDT ---
(In reply to comment #1)
> - rpmlint: NOT OK!!!
> efax.src: W: summary-ended-with-dot A program for faxing using a Class 1, 2 or
> 2.0 fax modem.
> efax.x86_64: W: log-files-without-logrotate /var/log/fax
> 
fixed in efax-0.9a-8.001114.fc15

> - package version: release should start with 0., alpha tag should go to release
> instead version
i don't want to add Epoch, please ignore

> according to Package Guidelines but as this package can be considered as
> successor to 0.9 (not
> pre 0.9) this is OK
> - requires: make and probably netpbm-progs (?) should be BuildRequires, not
> Requires, NOT OK!!!

make is required for Build -> BuildRequires: make
netpbm-progs is required to convert to fax format -> Requires: netpbm-progs


> - build flags: missing smp_mflags, custom build flags?, NOT OK!!!
fixed in efax-0.9a-8.001114.fc15
> 
> Than, please fix/comment issues.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.