[Bug 635788] Review Request: nautilus-terminal - Terminal embedded in Nautilus

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=635788

elad <el.il at doom.co.il> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |el.il at doom.co.il

--- Comment #4 from elad <el.il at doom.co.il> 2010-09-29 09:51:59 EDT ---
i will do an unofficial review.

+ = OK
- = NA
? = issue

+ Package meets naming and packaging guidelines
+ Spec file matches base package name.
+ Spec has consistent macro usage.
+ Meets Packaging Guidelines.
+ License
+ License field in spec matches
+ License file included in package
+ Spec in American English
+ Spec is legible.

+ Sources match upstream md5sum

- Package needs ExcludeArch
+ BuildRequires correct
- Spec handles locales/find_lang
- Package is relocatable and has a reason to be.
+ Package has %defattr and permissions on files is good.
+ Package has a correct %clean section.
+ Package has correct buildroot
+ Package is code or permissible content.
+ Doc subpackage needed/used.
+ Packages %doc files don't affect runtime.

- Headers/static libs in -devel subpackage.
- Spec has needed ldconfig in post and postun
- .pc files in -devel subpackage/requires pkgconfig
- .so files in -devel subpackage.
- -devel package Requires: %{name} = %{version}-%{release}
- .la files are removed.

- Package is a GUI app and has a .desktop file

+ Package compiles and builds on at least one arch.
Couldn't check on koji becuase i was unable to login because of an SSL error.
it compiles on my machine.

+ Package has no duplicate files in %files.
+ Package doesn't own any directories other packages own.
+ Package owns all the directories it creates.
+ No rpmlint output.

Seems that everything is OK with your package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.