[Bug 630932] Review Request: ibus-table-others- Various tables for IBus-Table

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=630932

--- Comment #5 from Chen Lei <supercyper1 at gmail.com> 2010-09-30 05:12:54 EDT ---
1. Since you already split ibus-table-others into several subpackages, so 
Obsoletes and Provides fields are useless.

2. %package ibus-table-code ->
%package -n ibus-table-code

%files ibus-table-code
->
%files -n ibus-table-code


3.
%files
%defattr(-,root,root,-)
%doc AUTHORS COPYING README

Those line can be removed.


4.

I suggest to add a blank line between Summary: and %description.


5.

I suggest to use rm and make to macros %__make and %__rm


6.
Requires:         ibus-table >= 1.2.0.20090912
You should move this line to every subpackage separately.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.