[Bug 675963] Review Request: perl-MDV-Packdrakeng - Simple Archive Extractor/Builder

bugzilla at redhat.com bugzilla at redhat.com
Fri Apr 1 08:56:43 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=675963

Petr Pisar <ppisar at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #3 from Petr Pisar <ppisar at redhat.com> 2011-04-01 04:56:42 EDT ---
Spec file changes:

--- perl-MDV-Packdrakeng.spec 2011-02-08 13:49:49.000000000 +0100
+++ perl-MDV-Packdrakeng.spec.1 2011-03-31 16:33:02.000000000 +0200
@@ -8,6 +8,10 @@
 Source0:       
http://www.cpan.org/authors/id/N/NA/NANARDON/MDV-Packdrakeng-%{version}.tar.gz
 BuildArch:      noarch
 BuildRequires:  perl(ExtUtils::MakeMaker)
+BuildRequires:  perl(File::Path)
+BuildRequires:  perl(Digest::MD5)
+BuildRequires:  perl(Test::More)
+BuildRequires:  perl(Compress::Zlib) 
 Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo
$version))

 %description

> TODO: BuildRequire perl(File::Path) (lib/MDV/Packdrakeng.pm:23) as the package
> can dual-live in the future (http://search.cpan.org/~dland/File-Path/).
+BuildRequires:  perl(File::Path)
Ok.

> FIX: BuildRequire perl(Test::More) to proceed all tests (t/01packdrakeng.t:6).
+BuildRequires:  perl(Test::More)
Ok.

> FIX: BuildRequire perl(Digest::MD5) to proceed all tests
> (t/01packdrakeng.t:7).
+BuildRequires:  perl(Digest::MD5)
Ok.

> TODO: BuildRequire perl(Compress::Zlib) to perform all tests
> (t/02methodusage.t:12).
+BuildRequires:  perl(Compress::Zlib)
Ok.

Package builds in F16
(http://koji.fedoraproject.org/koji/taskinfo?taskID=2965999). Ok.
All tests are performed in Koji. Ok.

Resolution: Package APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list