[Bug 691027] Review Request: n2n - A layer-two peer-to-peer virtual private network

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=691027

Michel Alexandre Salim <michel+fdr at sylvestre.me> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?,             |fedora-review+
                   |needinfo?(michel+fdr at sylves |
                   |tre.me)                     |

--- Comment #20 from Michel Alexandre Salim <michel+fdr at sylvestre.me> 2011-04-05 03:29:57 EDT ---
Splendid. APPROVED and SPONSORED -- oh, I forgot to mention this during the
review: you want to avoid explicit Requires: as much as possible.

In this case, if you do `rpm -qp --requires <the-binary-rpm>` you'll see that
it already depends on libcrypto, which is provided by openssl, so you don't
need to manually Requires: it (odd that rpmlint didn't complain).

Sometimes you do need it -- e.g. you want to tie down a particular version of
the library you depend on, normally when upstream notoriously break ABI without
bumping the soname (Mozilla's xulrunner is a particularly bad example).

No need to show me the fix though, just make it when you commit. Feel free to
ask me to review your next couple of packages, and please Cc: me on this and
the next couple of packages you maintain, just in case I can be of assistance.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.