[Bug 642583] Review Request: rubygem-rr - RR is a framework that features a rich selection of double techniques

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=642583

--- Comment #7 from Vít Ondruch <vondruch at redhat.com> 2011-04-05 12:02:33 EDT ---
* New upstream version available
  - Please consider updating to the latest version.

* RSpec 2.x
  - While upstream is using RSpec 1.3, it would be wise to use RSpec 2.x
available
    in F15 and Rawhide. However I am not sure it is feasible. So take it just
    as a hint.

* Cleaning
  - "rm -rf %{buildroot}" at the top of %install, %clean section
    are no longer needed:
    https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean

* Patching
  - The patching during installation changes unnecessarily the gem. Please do
    "gem install" in prep section. Execute the test in %{_builddir} instead of
    %{buildroot} and do patching right before the test start
  - Note that Bundler is already available in Fedora

* Move nonessential files into doc subpackage
  - Please consider moving nonessential files into -doc subpackage, e.g.
CHANGES,
    VERSION.yml, Gemfile

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.