[Bug 532241] Review Request: emacs-identica-mode - Identica mode for emacs.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=532241

Michel Alexandre Salim <michel+fdr at sylvestre.me> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?(sagarun at gmail.com
                   |                            |)

--- Comment #6 from Michel Alexandre Salim <michel+fdr at sylvestre.me> 2011-04-06 08:10:29 EDT ---
Hi Arun,

Sorry for the late reply! A couple of problems with the package right now:
- incomplete Build Requirement: you're using makeinfo, which is supplied by
  the texinfo package
- Upstream releases unversioned tarballs on their main download site, which
  makes it hard for someone to verify that the sources are accurate. Suggest
  contacting upstream, and meanwhile downloading the tarballs generated from
the
  Git tags instead (see detailed comments below)

Also, 1.1 is out now -- probably a good time to upgrade.


* TODO Review [72%]
  - [X] Names [2/2]
    - [X] Package name
    - [X] Spec name
  - [X] Package version [2/2]
 http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Package_Versioning
    - [X] Version number
   http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Version_Tag
    - [X] Release tag
   http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Release_Tag
  
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Pre-Release_packages
  - [X] Meets
[[http://fedoraproject.org/wiki/Packaging/Guidelines][guidelines]]
  - [-] Source files match upstream
 Upstream does not put the versioned source tarball in their download
 server; I suggest downloading the tarballs generated from the
 Git tags instead:
 http://git.savannah.gnu.org/cgit/identica-mode.git

 Contacting upstream is probably a good idea too, asking for the
 download tarballs to carry the version number
  - [X] [[http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries][No
bundled libraries]]
  - [X] License [4/4]
    - [X] License is Fedora-approved
    - [X] No licensing conflict
    - [X] License field accurate
    - [X] License included iff packaged by upstream
  - [-] rpmlint [1/2]
    - [X] on src.rpm
   emacs-identica-mode.src: W: file-size-mismatch identica-mode.tar.gz = 31463,
http://download.savannah.gnu.org/releases/identica-mode/identica-mode.tar.gz =
33026
          1 packages and 0 specfiles checked; 0 errors, 1 warnings.

   This is due to the source file problem, see above. Otherwise fine
    - [ ] on x86_64.rpm
  - [X] Language & locale [2/2]
    - [X] Spec in US English
    - [X] Spec legible
  - [-] Build [2/3]
    - [-] Koji results
   http://koji.fedoraproject.org/koji/taskinfo?taskID=2978357
    - [-] BRs complete
   makeinfo not found; needs to BR on texinfo
    - [X] Directory ownership
  - [X] Spec inspection [9/9]
    - [X] No duplicate files
    - [X] File permissions
    - [X] Filenames must be UTF-8
    - [X] no BuildRoot
([[https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag][except if
targeting RHEL5]])
    - [X] [RHEL]  %clean section
          https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean)
    - [X] [RHEL 5] %buildroot cleaned on %install
    - [X] Macro usage consistent
    - [X] Documentation [1/1]
      - [X] %doc files are non-essential
    - [X] Other subpackages
  - [X]
[[http://fedoraproject.org/wiki/Packaging/ScriptletSnippets][Scriptlets]] [1/1]
    - [X] info files

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.