[Bug 693493] Review Request: thunderbird-lightning - The calendar extension to Thunderbird

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=693493

--- Comment #7 from Orion Poplawski <orion at cora.nwra.com> 2011-04-06 14:05:38 EDT ---
(In reply to comment #6)
> + BAD : rpmlint is silent on both source and binary package.
> It isn't.
> bradford:build $ rpmlint -i thunderbird-lightning-1.0-0.39.b3pre.fc14.src.rpm
> RPMS/x86_64/thunderbird-lightning-*
> thunderbird-lightning.src: W: strange-permission thunderbird-mozconfig-branded
> 0755L

Fixed.  Note that this was copied from the current thunderbird package so is an
issue there.

> thunderbird-lightning.src: W: strange-permission find-external-requires 0755L
> A file that you listed to include in your package has strange permissions.
> Usually, a file should have 0644 permissions.

I think this has to be executable to work.

> thunderbird-lightning.src:19: W: macro-in-comment %define
> There is a unescaped macro after a shell style comment in the specfile. Macros
> are expanded everywhere, so check if it can cause a problem in this case and
> escape the macro with another leading % if appropriate.

Fixed.

> thunderbird-lightning.src: W: patch-not-applied Patch0:
> thunderbird-version.patch
> A patch is included in your package but was not applied. Refer to the patches
> documentation to see what's wrong.

False positive.  Again, same issue in thunderbird package.  We modify the patch
before applying it.

> thunderbird-lightning.src: W: %ifarch-applied-patch Patch6:
> mozilla-build-s390.patch
> A patch is applied inside an %ifarch block. Patches must be applied on all
> architectures and may contain necessary configure and/or code patch to be
> effective only on a given arch.

Fixed.

> thunderbird-lightning-debuginfo.x86_64: E: empty-debuginfo-package

I'm a bit at a loss.  This appears to be because libcalbasecomps.so is getting
stripped by the mozilla build/install process, but I can't figure out where. 
Any help would be appreciated.

> thunderbird-lightning.x86_64: E: script-without-shebang
> /usr/lib64/mozilla/extensions/{3550f703-e582-4d05-9a08-453d09bdfdc6}/{e2fda1a4-762b-4020-b5ad-a41df1933103}/calendar-js/calFreeBusyService.js
> thunderbird-lightning.x86_64: E: script-without-shebang
> /usr/lib64/mozilla/extensions/{3550f703-e582-4d05-9a08-453d09bdfdc6}/{e2fda1a4-762b-4020-b5ad-a41df1933103}/calendar-js/calAlarmMonitor.js

Fixed.

> + BAD : Runs rm -rf $RPM_BUILD_ROOT in %install
> It doesn't.

Not needed in F15, but since we have requests for F13/F14 I added it.

http://www.cora.nwra.com/~orion/fedora/thunderbird-lightning.spec
http://www.cora.nwra.com/~orion/fedora/thunderbird-lightning-1.0-0.40.b3pre.fc14.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.