[Bug 694287] Review Request: openCOLLADA - 3D import and export libraries

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=694287

Nicolas Chauvet (kwizart) <kwizart at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kwizart at gmail.com

--- Comment #1 from Nicolas Chauvet (kwizart) <kwizart at gmail.com> 2011-04-06 18:18:08 EDT ---
This is an informal review since I cannot sponsor you.



1/ Can you show the output of rpmlint on the src.rpm and the installed package.
Please fix the empty spaces in the middle of the lines for the %description

2/ Please remove Everything that is not usefull in fedora. This reduce
readability.
(specially everything before the 'Name' field as this is not usefull in
fedora).

3/ The version field is wrong, please follow:
https://fedoraproject.org/wiki/Packaging:Guidelines#Version_and_Release


4/ Uneeded BR: gcc-c++ - It is added by default, please remove.

5/ Buildroot is undeed nowdays:
https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag

6/ Remove spurious 'echo %{buildir}'

7/ rpm -E %{?jobsflag} is empty. fedora uses %{?_smp_mflags} instead. Please
remove the previous rpm macro.

8/ Where does CHANGES.TXT come from ? Please add an url if possible
-----------
# copy CHANGES.txt
cp %{S:1} ./ 
-----------
It's better to use install -p

9/ About: 
# Add some docs, need to fix eol encoding with dos2unix in some files
-> Please move this in %prep section

10/# Manual install ...
Are you sure this cannot be installed with scons ? You should fix it within
scons files then.

Here a preliminary pass for the review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.