[Bug 693425] Review Request: openerp - OpenERP business application

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=693425

David Nalley <david at gnsa.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at gnsa.us

--- Comment #20 from David Nalley <david at gnsa.us> 2011-04-09 23:30:21 EDT ---
Just a fair warning - you have at least two (I really quickly ran over the
source, there may be many more that I didn't find) bundled libraries in source.
These will need to be broken out and packaged separately (actually they may
already exist, which will make your job much easier) 

http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries

You've also got a VERY complex spec file, especially with it being the first
package you've submitted for review, and I question the need for a lot of that
complexity. 

Also, keep in mind that the purpose of the spec file is to install the
software, not to install and configure, using chkconfig to manipulate other
packages and other things like that are frowned upon. 

Sorry for seeming all negative, I really am excited about openERP dedicating
the resources to do this work, and I'll be happy to help you get it in
Fedora/EPEL.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.