[Bug 694994] Review Request: yoshimi - Rewrite of ZynAddSubFx aiming for better JACK support

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=694994

Brendan Jones <brendan.jones.it at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |brendan.jones.it at gmail.com

--- Comment #2 from Brendan Jones <brendan.jones.it at gmail.com> 2011-04-09 23:35:27 EDT ---
Hi Adam,

thanks for packaging this. Here's an informal review:

+ OK
- N/A
! Problem
? Not evaluated

fedora15:/home/Documents$ rpmlint
/var/lib/mock/fedora-15-x86_64/result/yoshimi-0.060.8-1.fc15.src.rpm 
yoshimi.src: W: spelling-error %description -l en_US microtonal -> micro tonal,
micro-tonal, microbial
1 packages and 0 specfiles checked; 0 errors, 1 warnings.


Required
========

[+] named according to the Package Naming Guidelines 
[+] The spec file name must match the base package %{name}, in the format
%{name}.spec 
[+] Meet the Packaging Guidelines
    *** (optional): no longer need %clean/cleaning of the buildroot in %install
unless building for F12 and below  or EPEL   
[+] Be licensed with a Fedora approved license and meet the Licensing
Guidelines 
[!] The License field in the package spec file must match the actual license 
 *** source includes header comments from ZynAddSubFX stating GPLv2+
[!] License file must be included in %doc
 *** COPYING file must be included in %doc, as well ass 0.60.8.notes
[+] The spec file must be written in American English
[+] The spec file for the package MUST be legible
[+] The sources used to build the package must match the upstream source
[+] Successfully compile and build into binary rpms on at least one primary
architecture
[-] Proper use of ExcludeArch 
[+] All build dependencies must be listed in BuildRequires
 *** consider adding hicolor-icon-theme to Requires
[+] The spec file MUST handle locales properly
[-] Shared library files (not just symlinks) in any of the dynamic linker's
default paths, must call ldconfig in %post and %postun
[+] Packages must NOT bundle copies of system libraries
[-] If the package is designed to be relocatable, the packager must state this
fact in the request for review, along with the rationalization for relocation
of that specific package
[+] A package must own all directories that it creates
directories under this
[!] A Fedora package must not list a file more than once in the spec file's
%files listings
 *** You only require  %{_datadir}/%{name} - it encompasses sub-directories
[+] Permissions on files must be set properly. Every %files section must
include a %defattr(...) line
[+] Each package must consistently use macros
[+] The package must contain code, or permissable content
[-] Large documentation files must go in a -doc subpackage
[+] If a package includes something as %doc, it must not affect the runtime of
the application
[-] Header files must be in a -devel package
[-] Static libraries must be in a -static package
[-] library files that end in .so (without suffix) must go in a -devel package
[-] devel packages must require the base package using a fully versioned
dependency
[-] Packages must NOT contain any .la libtool archives
[!] GUI apps must include a %{name}.desktop file, properly installed with
desktop-file-install in the %install section 
 *** Gnome uses "Comment" whereas KDE uses "GenericName". Should these be the
same?
[+] Packages must not own files or directories already owned by other packages
[+] All filenames in rpm packages must be valid UTF-8

Should Items
============
[-] the packager SHOULD query upstream for any missing license text files to
include it
[-] Non-English language support for description and summary sections in the
package spec if available
[-] The reviewer should test that the package builds in mock
[-] The package should compile and build into binary rpms on all supported
architectures
[+] The reviewer should test that the package functions as described
[+] If scriptlets are used, those scriptlets must be sane
[-] Usually, subpackages other than devel should require the base package using
a fully versioned dependency
[-] The placement of pkgconfig(.pc) should usually be placed in a -devel pkg
[-] If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin consider requiring the package which provides the file
instead of the file itself
[-] Should contain man pages for binaries/scripts
    *** no man pages in upstream package

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.