[Bug 687875] Review Request: aarddict - Multi-platform dictionary and offline Wikipedia reader

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=687875

--- Comment #4 from PRABIN KUMAR DATTA <linux.n.pkd at gmail.com> 2011-04-10 10:53:53 EDT ---
Hi! David,
Thank You, for your reply!
/==
> This is unnecessary, and in fact improper,: 
> %doc LICENSE doc/*

> It should be: 
> %doc LICENSE
==/

Okay! I have added doc under a separate doc macro (used another package from
fedora source repo as a reference for this).

/==
> I think the following: 
> %{python_sitelib}/%{name}/*.*
> %{python_sitelib}/%{name}/icons/*
> %{python_sitelib}/%{name}/locale/qt_el.qm
> %{python_sitelib}/%{name}/locale/qt_ru.qm

> could be reduced to: 
> %{python_sitelib}/%{name}
==/

If I try to write it as you have suggested then it will add two language files
which are:
* /usr/lib/python2.7/site-packages/aarddict/locale/ru/LC_MESSAGES/aarddict.mo
and
* /usr/lib/python2.7/site-packages/aarddict/locale/el/LC_MESSAGES/aarddict.mo

But these two files are already added using "%files -f %{name}.lang"
So, this will result in duplication of two same files.

Thank You!
Have a Nice Day!
---

Updated:
Spec URL: http://prabindatta.fedorapeople.org/SPECS/aarddict.spec
SRPM URL:
http://prabindatta.fedorapeople.org/SRPMS/aarddict-0.9.1-2.fc15.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.