[Bug 690728] Review Request: Nitrate - A test case management system written in Django

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=690728

--- Comment #10 from Michel Alexandre Salim <michel+fdr at sylvestre.me> 2011-04-10 16:48:11 EDT ---
In addition to what Michael pointed out -- it should be
 %{_datadir}/%{name} so the directory itself is RPM-owned,

- source line is invalid. It includes %{release} which would include the
disttag that spectool is called from (e.g. 4.fc15 instead of 4). Any reason
spec releases should have matching tarballs? normally a single tarball is
released per version, and you bump the version number if you need to release a
fix. The spec release simply tracks spec changes

- BuildArch should be noarch since the package does not contain arch-dependent
files

- the comment for the section dealing with static content is just wrong. They
  are not being moved from arch-specific Python directories (in fact the
package
  is actually noarch anyway) but are copied from the source directory

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.