[Bug 694950] Review Request: torrent-search - A torrent searching graphical application

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=694950

Fabian Affolter <fabian at bernewireless.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fabian at bernewireless.net

--- Comment #1 from Fabian Affolter <fabian at bernewireless.net> 2011-04-11 02:45:11 EDT ---
Just some quick comments on your spec file:

- You are mixing macro and variable style
 
https://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS
- There is stuff for zsh. Wouldn't it be a good idea to put this in a
subpackage?
- There is an empty %doc line. The html docs can go there.
- There is a missing BR for the locale files
  https://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.