[Bug 695022] Review Request: pygtkhelpers - assists the building of PyGTK applications
bugzilla at redhat.com
bugzilla at redhat.com
Mon Apr 11 07:09:37 UTC 2011
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=695022
Fabian Affolter <fabian at bernewireless.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fabian at bernewireless.net
--- Comment #3 from Fabian Affolter <fabian at bernewireless.net> 2011-04-11 03:09:37 EDT ---
Just some quick comments:
- The website and the LICENSE.txt claims that the license is LGPL and not GPL.
- There are examples in the source. Wouldn't it be a good idea to put those
examples in a subpackage?
- The '%{!?python_sitearch:...' line is not needed.
- I don't think that console.py needs 755. Removing the shebang can calm
rpmlint down.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list