[Bug 640455] Review Request: python-pyro - Pyro is short for PYthon Remote Objects.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=640455

--- Comment #12 from Haïkel Guémar <karlthered at gmail.com> 2011-04-11 18:50:53 EDT ---
As promised, i finished reviewing your package today
python-pyro (python package)

MUST: rpmlint must be run on src.rpm and rpm: OK
$ rpmlint -iv python-pyro-4.3-1.fc14.noarch.rpm
python-pyro.noarch: I: checking
python-pyro.noarch: I: checking-url
http://www.xs4all.nl/~irmen/pyro4/index.html (timeout 10 seconds)
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint -iv python-pyro-4.3-1.fc14.src.rpm 
python-pyro.src: I: checking
python-pyro.src: I: checking-url http://www.xs4all.nl/~irmen/pyro4/index.html
(timeout 10 seconds)
python-pyro.src: I: checking-url
http://www.xs4all.nl/~irmen/pyro4/download/Pyro4-4.3.tar.gz (timeout 10
seconds)
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Note: the summary - PYthon Remote Objects - is acceptable since it represents
the name of the package

MUST: package named accordingly to package naming guidelines: OK

MUST: spec file name match %{name}: OK

MUST: licensed according a Fedora compliant license: OK (MIT - license file
included)

MUST: License field in spec match actual license: OK

MUST: spec in legible american english: OK

MUST: sources provided match upstream's OK
provided sources sha1sum: 8d654e0fa662b9bdab325c836dbd0af349370f93
upstream sources sha1sum: 8d654e0fa662b9bdab325c836dbd0af349370f93

MUST: package sucessfully compiles on at least one primary architecture (all of
them: x86 and x86_64 under mock for fedora-devel)

MUST: all build dependencies are listed in BR: OK

MUST: package does not list a file more than once in %files section: OK

MUST: permissions are properly set: OK

MUST: package consistenly uses macros: OK

MUST: package contains permissable content: OK

MUST: all filenames are valid UTF-8: OK

SHOULD: the module provided works (tested with python 2.7 and a self-hacked
version on python 3.2): OK

Though it is not mandatory, adding python3 support is strongly recommended
especially when it's supported by upstream which is the case for python-pyro >=
4.3

Since, it's trivial to add python3 support in python-pyro and everything is OK,
my blessing will be given as soon as it's added (Think of it as a good deed to
push forward python3).

===> Here's a modified version of python-pyro.spec with a working python3
support, feel free to use it as a basis.
http://hguemar.fedorapeople.org/reviewer/python-pyro/python-pyro.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.