[Bug 693425] Review Request: openerp - OpenERP business application

bugzilla at redhat.com bugzilla at redhat.com
Tue Apr 12 09:01:41 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=693425

--- Comment #22 from Panos Christeas <xrg at hellug.gr> 2011-04-12 05:01:40 EDT ---
A little update of the ongoing progress:
Most of the remarks of this "bug" thread have been honoured in the spec file,
as can be seen in the git repo.
I still have 3 points, please advise:
  1. IMHO it's better to have 1x spec file for both client and server (and any
meta-packages, if needed). Is that such a bad practice? Versioning, according
to company policy _is_ the same for both sources. We don't do individual
releases.
  2. I'd prefer to abandon the old statically allocated user id = 13 for
tinyerp and instead follow modern guidelines for an 'openerp' user.
  3. Unbundling of SpiffGtkWidgets is not immediately feasible. We do have
enough custom code[2] in there to say[1] that we can't use upstream. OTOH,
fortunately, I had already formed a Git branch with our work, and published to
GitHub. This means, I can push for merging[3], although we may not have the
changes and repackaging of the upstream project in time. That said, I
definitely see that as a _temporary_ request, pending unbundling of the library
as soon as possible.

The rpmlint errors (about file permissions etc.) are not all cleared yet,
because I wait our main repo (of code) to publish a new tarball with the fixes.
I'm trying to put as many of the necessary improvements in the code, rather
than the .spec .

Thanks for your attention.

[1] switching to "upstream" will need some time just because of testing, in any
case. 
[2] yes, you can call it "forking on laziness", it's our fault.
[3] this would also involve a series of iterations so that other projects won't
be affected by the changes we may introduce to SpiffGtkWidgets.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list