[Bug 596461] Review Request: lzma-sdk - SDK for lzma compression

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=596461

--- Comment #52 from Jason Tibbitts <tibbs at math.uh.edu> 2011-04-12 15:20:19 EDT ---
Hmm, I'm not seeing any change in that perl(SevenZip) thing, but I'm not sure I
understand why.  The macro usage seems proper but it doesn't seem to actually
filter anything.  I used the rpm 4.9 filtering macro and it works fine:
  %define __provides_exclude .*SevenZip.*
but it looks like you intend to support old releases with this spec so that
won't work generally.

I'm also still seeing some files that need EOL conversion:

lzma-sdk.noarch: W: wrong-file-end-of-line-encoding
  /usr/share/doc/lzma-sdk-4.6.5/7zFormat.txt
lzma-sdk.noarch: W: wrong-file-end-of-line-encoding
  /usr/share/doc/lzma-sdk-4.6.5/7zC.txt
lzma-sdk.noarch: W: wrong-file-end-of-line-encoding
  /usr/share/doc/lzma-sdk-4.6.5/history.txt
lzma-sdk.noarch: W: wrong-file-end-of-line-encoding
  /usr/share/doc/lzma-sdk-4.6.5/lzma.txt
lzma-sdk.noarch: W: wrong-file-end-of-line-encoding
  /usr/share/doc/lzma-sdk-4.6.5/Methods.txt

Finally, the spec seems to have grown a mixed-use-of-spaces-and-tabs thing (tab
on the Source1: line) which isn't a particularly big deal but I guess you might
want to fix it if you're in there.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.