[Bug 696518] Review Request: python-rhev - Python binding to Red Hat Enterprise Virtualization's REST API

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=696518

Lubomir Rintel <lkundrak at v3.sk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #2 from Lubomir Rintel <lkundrak at v3.sk> 2011-04-14 05:39:58 EDT ---
* Version number correct
* Builds fine in mock
* Filelist sane
* Requires/provides sane
* SPEC file, clean and legible

0.) Not named correctly

The source package should be named rhevm-api; you should use %package -n
python-rhev to make a python-rhev subpackage.

The rationale behind that is that the (source) package name should correspond
to upstream project name. Also, it looks like there are java (and other
languages) sources in the tree, this would make it easier and more consistent
to package them up if someone wishes to.

1.) Revision number not correct
  IS: 1%{?dist}.20110316git
  SHOULD BE: 1.20110316git%{?dist}

2.) License tag not correct

This is mess and should be fixed upstream: LICENSE file is LGPLv2, while python
files referring to it are MIT:

# This file is part of python-rhev. python-rhev is free software that is
# made available under the MIT license. Consult the file "LICENSE" that
# is distributed together with this file for the exact licensing terms.

Apparently, there are LGPLv2-ed files there as well though.

3.) python-rhev-0.9-fix-dependencies.patch

Should be submitted upstream.

4.) The description sounds weird:

Python-RHEV is a Python binding to Red Hat Enterprise Virtualization's
REST API. Object oriented. Up to Date. Validating.

Maybe using full sentences would make more sense?

Python-RHEV is a validating object-oriented Python binding to Red Hat
Enterprise Virtualization's REST API.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.