[Bug 691818] Review Request: openpts - TCG Platform Trust Service (PTS) for embedded devices

bugzilla at redhat.com bugzilla at redhat.com
Thu Apr 14 16:45:06 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=691818

Miloslav Trmač <mitr at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|needinfo?(mitr at redhat.com)  |needinfo?(avagarwa at redhat.c
                   |                            |om)

--- Comment #3 from Miloslav Trmač <mitr at redhat.com> 2011-04-14 12:45:05 EDT ---
Thanks for the update.

blocker:
(In reply to comment #2)
> (In reply to comment #1)
> > * Source0: points to a HTML page.
> >   If it is possible to use something similar to
> > https://fedoraproject.org/wiki/Packaging:SourceURL#Sourceforge.net to get a
> > direct URL to the tarball, this should be done.  This problem is not a blocker
> > if no such option exists, obviously.
> 
> Can you please check again, because for me, it points to the file and lets me
> download the package?

This is what I get:
> $ wget 'http://sourceforge.jp/projects/openpts/downloads/51233/openpts-0.2.3.tgz'
...
> --2011-04-14 18:35:32--  http://sourceforge.jp/projects/openpts/downloads/51233/openpts-0.2.3.tgz/
> Length: unspecified [text/html]
> Saving to: „index.html“
... and the file indeed contains HTML.

Are you seeing something different?  Is it possible that the behavior depends
on the location of the client?


non-blocker:
> > * Including the documenation from doc/ would probably be useful to users.
> >   Please also consider including ChangeLog in %doc.
> 
> Fixed.
I was thinking more of the manuals; the .eps files are included in the .tex
files and probably not intended to be shipped stand-alone.  It seems that the
manuals are not built by default.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


More information about the package-review mailing list