[Bug 691818] Review Request: openpts - TCG Platform Trust Service (PTS) for embedded devices

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=691818

Miloslav Trmač <mitr at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?,             |fedora-review+
                   |needinfo?(mitr at redhat.com)  |

--- Comment #5 from Miloslav Trmač <mitr at redhat.com> 2011-04-14 14:21:17 EDT ---
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > (In reply to comment #1)
> > > > * Source0: points to a HTML page.
> > > >   If it is possible to use something similar to
> > > > https://fedoraproject.org/wiki/Packaging:SourceURL#Sourceforge.net to get a
> > > > direct URL to the tarball, this should be done.  This problem is not a blocker
> > > > if no such option exists, obviously.

> I am seeing same behaviour with wget. However, if you try to download by
> clicking on the link that takes a bit of time before it asks you to save the
> file. Not sure if this is the reason that wget can not download and outputs
> this error "Length: unspecified [text/html]".
Right, this is done inside the html file.  So using this URL won't work with
automated Source: checkers and the like.

> Anyway that is the only upstream link I have right now. Please let me know if
> this is OK to go ahead.
We don't have anything better, so this will have to do.


> > non-blocker:
> > > > * Including the documenation from doc/ would probably be useful to users.
> > > >   Please also consider including ChangeLog in %doc.
> > > 
> > > Fixed.
> > I was thinking more of the manuals; the .eps files are included in the .tex
> > files and probably not intended to be shipped stand-alone.  It seems that the
> > manuals are not built by default.
> 
> You are right and since *.tex are not compiled to get pdf or eps, I did not
> want to include them. If you want, I can remove *.eps. Although I though that
> something is better than nothing ;-) . 
> 
> Again, please let me know as the above things are not blocker, then is it OK to
> get ahead with the review?
Sure.

ACCEPting openpts-0.2.3-2.fc16.src.rpm .

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.