[Bug 696357] Review Request: fedora-logo-gnome-shell-extension - adds a Fedora logo to Gnome shell's Activities button

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=696357

--- Comment #2 from Mohamed El Morabity <pikachu.2014 at gmail.com> 2011-04-14 22:54:17 EDT ---
A quite good package, simple but works well :). A few comments anyway:

* maybe your package should be renamed « gnome-shell-extension-fedora-logo » or
« gnome-shell-fedora-logo », at least to respect the naming guidelines for
addons packages (see
http://fedoraproject.org/wiki/PackageNamingGuidelines#Addon_Packages_.28General.29).

* the fedora-logos package provides a « system-logos » capacity, as well as the
generic-logos package (and probably the redhat-logos in RHEL also). Why not
setting system-logos as Requires instead of fedora-logos, so that your package
would be usable without any change in Fedora as well as in any Fedora-derivated
distribution?

* about the URL tag: why not simply use http://sources.venemo.net/? The URL tag
is intended to point to the project website, no matter how small it is. If it's
not the solution you prefer, you could create a basic page in your
fedorapeople.org space (or wherever you can) containing the description of the
package and links to the sources.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.