[Bug 682666] Review Request: DeTex - A program to remove TeX constructs from a text file

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=682666

--- Comment #4 from Mohamed El Morabity <pikachu.2014 at gmail.com> 2011-04-16 06:57:09 EDT ---
That looks good :)

According to the guidelines, patches in a .spec should have a comment. This
concerns also fixes made through sed.
This will not (only) help the reviewer, but it help you as a maintainer.
By the way, why these lines in %prep?
   sed -i "/rm -f xxx\.l/d" Makefile
   sed -i "s/mv lex\.yy\.c detex\.c/cp lex\.yy\.c detex\.c/" Makefile

In %description, use « DeTeX » instead of « Detex ». This seems to be the «
official » name of the application.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.