[Bug 674082] Review Request: mchange-commons - A collection of general purpose utilities for c3p0

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=674082

Sebastian Dziallas <sebastian at when.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #9 from Sebastian Dziallas <sebastian at when.com> 2011-04-17 21:58:33 EDT ---
Mat, when I get a spare minute, I will. :)

Here's the official review. It looks pretty good so far. Could you pull again
from upstream to make sure we get the latest version and match upstream? Also,
according to the guidelines, you 'should' query upstream to include the license
file, but I'm not going to block on that.

Please pull the latest version and go ahead then.

Otherwise: APPROVED.

[  OK  ] specfiles match:
55b22670abfe91bcd3b25625d58da15b131f6f911f8ff37ffdb4644aa937ef73
[ FAIL ] source files match upstream:

2b7c533be6f083239cc215bf850d39cbf5b5cafd59e0b5cd2ee1126db3b219bf is the latest
upstream
d2050642f67e7566e9878575e75ba81a973747c673079de605326d67594a1fda is being
packaged

[  OK  ] package meets naming and versioning guidelines.
[  OK  ] spec is properly named, cleanly written, and uses macros consistently.
[  OK  ] dist tag is present.
[  NA  ] build root is correct.
[  OK  ] license field matches the actual license.
[  OK  ] license is open source-compatible.
[ FAIL ] license text included in package.
[  OK  ] latest version is being packaged.
[  OK  ] BuildRequires are proper.
[  NA  ] compiler flags are appropriate.
[  OK  ] %clean is present. 
[  OK  ] package builds in mock.
[  OK  ] package installs properly.
[  NA  ] debuginfo package looks complete.
[  OK  ] rpmlint is silent.

[sebastian at bear rpmbuild]$ rpmlint
./RPMS/noarch/mchange-commons-0.2-0.3.20110130hg.fc14.noarch.rpm 
mchange-commons.noarch: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

[  OK  ] final provides and requires are sane
[  NA  ] %check is present and all tests pass:
[  OK  ] no shared libraries are added to the regular linker search paths.
[  OK  ] owns the directories it creates. 
[  OK  ] doesn't own any directories it shouldn't.
[  OK  ] no duplicates in %files.
[  OK  ] file permissions are appropriate.
[  NA  ] scriptlets match those on ScriptletSnippets page.
[  OK  ] code, not content.
[  NA  ] documentation is small, so no -docs subpackage is necessary.
[  NA  ] %docs are not necessary for the proper functioning of the package.
[  OK  ] no headers.
[  OK  ] no pkgconfig files.
[  OK  ] no libtool .la droppings.
[  NA  ] desktop files valid and installed properly.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.