[Bug 593559] Review Request: protobuf-c - C bindings for Google's Protocol Buffers

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=593559

--- Comment #20 from Martin Gieseking <martin.gieseking at uos.de> 2011-04-19 09:09:16 EDT ---
OK, the package looks almost good so far. Just a couple of minor notes:

- Change the Group of the base package to "System Environment/Libraries".

- Please add a short info about protobuf to the %description, e.g. 
  "Protocol Buffers are a way of encoding structured data in an efficient yet 
  extensible format." Even if this is a C language extension of protobuf, it 
  might help the user to get a clue about what this is all about.

- The %description of the devel package should be a complete sentence too 
  (with final dot).

- As already suggested by Bobby, I recommend to update the package to the 
  latest upstream version. Check whether the new version build with 
  make %{?_smp_mflags}.

- As far as I can see, protobuf-devel is not required to develop applications
  with protobuf-c. Thus, you can drop Requires: protobuf-devel from the 
  devel package.

- If you don't want to maintain this package for EPEL < 6, you can drop all 
  the buildroot stuff (BuildRoot tag, rm -rf $RPM_BUILD_ROOT in %install, and 
  the %clean section). 

- File LICENSE is present in the SVN repo but missing in the tarball. Please 
  ask upstream to add it to future releases. Until then, grab the file from
  the repo and add it to the base package:
  Source1: http://code.google.com/p/protobuf-c/source/browse/tags/0.15/LICENSE
  in %prep: cp %{SOURCE1} .
  in %files: %doc LICENSE

- Caution: Upstream has changed the license of the current development 
  version to BSD. So keep in mind to adapt the License field and file LICENSE 
  once you update the package in the future.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.