[Bug 690854] Review Request: wimax-network-service - WiMAX Network Service for the Intel 2400m

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=690854

--- Comment #1 from Jiri Popelka <jpopelka at redhat.com> 2011-04-19 13:21:51 EDT ---
[NO] MUST: rpmlint must be run on the source rpm
           and all binary rpms the build produces.

 => Please fix or comment the following Errors+Warning:

wimax-network-service.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/wimaxd
['/usr/lib64']
The binary or shared library defines `RPATH'. Usually this is a bad thing
because it hardcodes the path to search libraries and so makes it difficult to
move libraries around.  Most likely you will find a Makefile with a line like:
gcc test.o -o test -Wl,--rpath.  Also, sometimes configure scripts provide a
--disable-rpath flag to avoid this.

wimax-network-service.x86_64: E: incoherent-logrotate-file
/etc/logrotate.d/wimax.conf
Your logrotate file should be named /etc/logrotate.d/<package name>.

wimax-network-service.src: W: no-version-in-last-changelog
The latest changelog entry doesn't contain a version. Please insert the
version that is coherent with the version of the package and rebuild it.

[OK] MUST: The package must be named according to the Package Naming
Guidelines.
[OK] MUST: The spec file name must match the base package %{name},
           in the format %{name}.spec unless your package has an exemption.
[OK] MUST: The package must meet the Packaging Guidelines.
[OK] MUST: The package must be licensed with a Fedora approved license
           and meet the Licensing Guidelines.
[OK] MUST: The License field in the package spec file must match the actual
license.
[OK] MUST: If (and only if) the source package includes the text
           of the license(s) in its own file, then that file,
           containing the text of the license(s) for the package
           must be included in %doc.
[OK] MUST: The spec file must be written in American English.
[OK] MUST: The spec file for the package MUST be legible.
[OK] MUST: The sources used to build the package must match
           the upstream source, as provided in the spec URL.
           If no upstream URL can be specified for this package,
           please see the Source URL Guidelines for how to deal with this.
[OK] MUST: The package MUST successfully compile and build
           into binary rpms on at least one primary architecture.
[OK] MUST: If the package does not successfully compile, build or work
           on an architecture, then those architectures should
           be listed in the spec in ExcludeArch.
[OK] MUST: All build dependencies must be listed in BuildRequires.
[NA] MUST: The spec file MUST handle locales properly.
[OK] MUST: Every binary RPM package (or subpackage) which
           stores shared library files (not just symlinks)
           in any of the dynamic linker's default paths,
           must call ldconfig in %post and %postun.
[OK] MUST: Packages must NOT bundle copies of system libraries.
[NA] MUST: If the package is designed to be relocatable,
           the packager must state this fact in the request for review.
[OK] MUST: A package must own all directories that it creates.
[OK] MUST: A Fedora package must not list a file more than once
           in the spec file's %files listings.
[OK] MUST: Permissions on files must be set properly.
           Executables should be set with executable permissions.
           Every %files section must include a %defattr(...) line.
[OK] MUST: Each package must consistently use macros.
 => Consider using these macros instead of hardcoded paths in %files section:
  %{_sysconfdir}        /etc
  %{_bindir}            /usr/bin
  %{_sharedstatedir}    /var/lib

[OK] MUST: The package must contain code, or permissable content.
[NA] MUST: Large documentation files must go in a -doc subpackage.
[OK] MUST: If a package includes something as %doc,
           it must not affect the runtime of the application.
[OK] MUST: Header files must be in a -devel package.
[NA] MUST: Static libraries must be in a -static package.
[OK] MUST: If a package contains library files with a suffix
           (e.g. libfoo.so.1.1), then library files that
           end in .so (without suffix) must go in a -devel package.
[OK] MUST: In the vast majority of cases, devel packages
           must require the base package using a fully versioned dependency:
           Requires: %{name}%{?_isa} = %{version}-%{release}
[OK] MUST: Packages must NOT contain any .la libtool archives,
           these must be removed in the spec if they are built.
[NA] MUST: Packages containing GUI applications must include
           a %{name}.desktop file.
[OK] MUST: Packages must not own files or directories
           already owned by other packages.
[OK] MUST: All filenames in rpm packages must be valid UTF-8.

[OK] SHOULD: The placement of pkgconfig(.pc) files depends
             on their usecase, and this is usually for
             development purposes, so should be placed in a -devel pkg.
[OK] SHOULD: your package should contain man pages for binaries/scripts.
             If it doesn't, work with upstream
             to add them where they make sense.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.