[Bug 697778] Review Request: rubygem-formtastic - A Rails form builder plugin/gem with semantically rich and accessible markup

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=697778

--- Comment #2 from Parag AN(पराग) <panemade at gmail.com> 2011-04-20 02:23:01 EDT ---
Review:
1) koji build->http://koji.fedoraproject.org/koji/taskinfo?taskID=3012790
2) rpmlint output is
rubygem-formtastic.noarch: W: unexpanded-macro
/usr/lib/ruby/gems/1.8/doc/formtastic-1.2.3/ri/Formtastic/SemanticFormBuilder/options_require_validation%3f-i.yaml
%3f
rubygem-formtastic.noarch: W: unexpanded-macro
/usr/lib/ruby/gems/1.8/doc/formtastic-1.2.3/ri/Formtastic/SemanticFormBuilder/detect_label_and_value_method%21-i.yaml
%21
rubygem-formtastic.noarch: W: unexpanded-macro
/usr/lib/ruby/gems/1.8/doc/formtastic-1.2.3/ri/Formtastic/Util/rails3%3f-i.yaml
%3f
rubygem-formtastic.noarch: W: unexpanded-macro
/usr/lib/ruby/gems/1.8/doc/formtastic-1.2.3/ri/Formtastic/SemanticFormBuilder/has_errors%3f-i.yaml
%3f
rubygem-formtastic.noarch: W: unexpanded-macro
/usr/lib/ruby/gems/1.8/doc/formtastic-1.2.3/ri/Formtastic/SemanticFormBuilder/is_file%3f-i.yaml
%3f
rubygem-formtastic.noarch: W: unexpanded-macro
/usr/lib/ruby/gems/1.8/doc/formtastic-1.2.3/ri/Formtastic/SemanticFormBuilder/render_inline_errors%3f-i.yaml
%3f

==> But as upstream has introduced naming for above files we can ignore this.
3) upstream source verified as
b1e67ba4cd4574a307a868af585a9243a3a8df54  formtastic-1.2.3.gem
b1e67ba4cd4574a307a868af585a9243a3a8df54  ../SOURCES/formtastic-1.2.3.gem

suggestions
1) I think you can drop the gem word from summary so it will be 
"A Rails form builder plugin with semantically rich and accessible markup"

Description can be added as
"Formtastic is a Rails FormBuilder DSL (with some other goodies) to make it far
easier to create beautiful, semantically rich, syntactically awesome, readily
stylable and wonderfully accessible HTML forms in your Rails applications."

2)Generally we don't want to add versions to Requires also so that yum should
always pull latest dependencies. Please drop the versions.

3) fix the duplicate lines 
Requires: rubygem(i18n) => 0.4
Requires: rubygem(i18n) < 1


4) I think you can also add -doc subpackage

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.